Expand Action(IForgeAction&IForgeArmPose) #46
+150
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, please wait for Rong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expand the EnumAction and ArmPose
but remain the vanillan
if.The Functional Interface
We use functional interface to expand the EnumAction and ArmPose. This design is from the forge hook of
EnumEnchantmentType.Usually, we use
EnumHelperto add a enum, this means what we could do is just aload a reference. We could not override it, this is why we use functional interface to expand it.The Legacy Mods
As far as i know, there are lots of mods have impled the expandation of EnumAction or ArmPose use their own mixin or asm.
To preserve compatibility, I don't remove the original if chain, although using polymorphism would look nicer now.